-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Libssh test fix #412
Libssh test fix #412
Conversation
Signed-off-by: Jakub Jelen <[email protected]>
Signed-off-by: Jakub Jelen <[email protected]>
sigh ... sounds like the engine.h is included in two places but we removed only one. Will fix with another MR on libssh side. |
Pushed in here with some more assorted stuff: |
@@ -47,7 +47,7 @@ pkcs11_provider_setup() | |||
|
|||
libssh_setup() | |||
{ | |||
title PRAM "Clone, setup and build libssh" | |||
title PARA "Clone, setup and build libssh" | |||
|
|||
git clone https://gitlab.com/libssh/libssh-mirror.git \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also fix the link please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This git forge is running on some Andreas servers. I do not know how much traffic the cloning from CI is going to generate so I would prefer to keep the gitlab mirror as that is automatically updated every hour or so and is more likely to be present.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, yes, that makes sense, please disregard my comment :). It looks like this mirror is up to date.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
With recent rebuild of gnutls in rawhide now all tests pass, so this is finally fixed. |
Description
Minor fixes to the libssh integration test
Reviewer's checklist: