Refactor setup #436
Merged
Refactor setup #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NOTE: Kryoptic stuff will fail until latchset/kryoptic#84 is merged |
simo5
force-pushed
the
singlesetup
branch
3 times, most recently
from
0209be8 to
d83eace
Compare
|
NOTE: softoken fails on Centos9 because it does not support NSS_LIB_PARAMS yet I think ... |
Jakuje
reviewed
Aug 27, 2024
|
@Jakuje what should we do with NSS on CentOS 9 ? |
Probably yes. I think CentOS 9 should get the NSS update any time soon (I thought this already some months back though). |
simo5
force-pushed
the
singlesetup
branch
5 times, most recently
from
8dd5cff to
d51d251
Compare
|
@Jakuje Best I could do is to make the C9s test "pass" without actually doing anything if the NSS version is too old. |
Jakuje
reviewed
Aug 28, 2024
simo5
force-pushed
the
singlesetup
branch
2 times, most recently
from
82f466a to
6212f8b
Compare
Jakuje
previously approved these changes
Aug 29, 2024
Move only the token specific initialization into custom setup files, and the use pkcs11-tool and a single script to set up all the keys and certificates. Signed-off-by: Simo Sorce <[email protected]>
Unfortunately there does not seem to be a real way to skip the test, this just marks it as pass without doing nothing. Hopefully we can drop this special case soon as c9s get's a new version of NSS. Signed-off-by: Simo Sorce <[email protected]>
Signed-off-by: Simo Sorce <[email protected]>
simo5
added
covscan-ok
|
Thanks for the review @Jakuje |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move only the token specific initialization into custom setup files, and the use pkcs11-tool and a single script to set up all the keys and certificates.
Description
The main work of setting up tokens is now in test/setup.sh and each token type has a -init.sh file that does the bare minimum custom initialization needed.
Checklist
[ ] Code modified for feature[ ] Test suite updated with negative tests[ ] Documentation updatedReviewer's checklist:
[ ] Any issues marked for closing are addressed[ ] This feature/change has adequate documentation added[ ] Coverity Scan has run if needed (code PR) and no new defects were found