Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sundry fixes #448

Merged
merged 4 commits into from
Oct 9, 2024
Merged

Sundry fixes #448

merged 4 commits into from
Oct 9, 2024

Conversation

simo5
Copy link
Member

@simo5 simo5 commented Oct 8, 2024 •
edited
Loading

Description

Various fixes to issues I found while trying to understand what is going on with #266

Checklist

  • Code modified for feature
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • [ ] Documentation updated

Reviewer's checklist:

  • Any issues marked for closing are addressed
  • There is a test suite reasonably covering new functionality or modifications
  • This feature/change has adequate documentation added
  • Code conform to coding style that today cannot yet be enforced via the check style test
  • Commits have short titles and sensible commit messages
  • Coverity Scan has run if needed (code PR) and no new defects were found

@simo5 simo5 requested a review from The-Mule October 8, 2024 13:51
simo5 added 4 commits October 8, 2024 09:54
@simo5
Fix tests/util.c condition check
51fa94a 
Signed-off-by: Simo Sorce <[email protected]>
@simo5
Fix handling of imported keys with RSA
d727a8c 
Signed-off-by: Simo Sorce <[email protected]>
@simo5
Ensure pools are consistent when we store objects
1d2a53b 
This was broken by a recent commit as slotid is populated when a mock
object is actually stored in the session, but the object was not added
to the pool, leading the code that frees object to complain the pool was
in an inconsistent state because the object could not be found there.

Signed-off-by: Simo Sorce <[email protected]>
@simo5
Fix TLS Script
8b4060c 
Not sure "how" this fixes the tests, but without these changes we get an
error in the last TLS tests with latest code changes, and this error
goes away when modifying the expect script to be more verbose.

Signed-off-by: Simo Sorce <[email protected]>
The-Mule
The-Mule approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@The-Mule The-Mule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simo5 simo5 added the covscan Triggers Coverity Scanner label Oct 9, 2024
@github-actions github-actions bot removed the covscan Triggers Coverity Scanner label Oct 9, 2024
@simo5 simo5 added the covscan-ok Coverity scan passed label Oct 9, 2024
@simo5 simo5 merged commit d6510d6 into latchset:main Oct 9, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@The-Mule The-Mule The-Mule approved these changes

Assignees
No one assigned
Labels
covscan-ok Coverity scan passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simo5 @The-Mule