Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag new functions in lthooks.dtx #1241

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

jlaurens
Copy link
Contributor

New functions were recently added. The online doc won't always reflect the actual distribution of the reader. We tag the new functions as added to the 2023-06-01 release. This is not very pretty for L3 API because new and old functions are documented altogether. But this problem will disappear in a forthcoming release.

READ ME FIRST: Please understand that in most cases we will not be able to merge a pull request because there are a lot of internal activities needed when updating the LaTeX2e sources. If you have a code suggestion please discuss it with the team first.

Pull requests in this repository are intended for LaTeX Team members only.

Internal housekeeping

Status of pull request

  • Feedback wanted
  • Under development
  • Ready to merge

Checklist of required changes before merge will be approved

  • Test file(s) added
  • Version and date string updated in changed source files
  • Relevant \changes entries in source included
  • Relevant changes.txt updated
  • Rollback provided (if necessary)?
  • ltnewsX.tex (and/or latexchanges.tex) updated

New functions were recently added. The online doc won't always reflect the actual distribution of the reader.
We tag the new functions as added to the 2023-06-01 release. This is not very pretty for L3 API because new and old functions are documented altogether. But this problem will disappear in a forthcoming release.
Copy link
Member

@PhelypeOleinik PhelypeOleinik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs updating the date in lthooks.dtx ebfore merging. Otherwise looks ok

@jlaurens
Copy link
Contributor Author

Sorry for this newbie question: who is responsible for the date/version change in the source file?

@josephwright
Copy link
Member

@jlaurens It's your PR, so you :) Code revision need a version and date change, documentation-only revisions need only a date change

@FrankMittelbach FrankMittelbach merged commit 45c76f0 into latex3:develop Jan 16, 2024
39 checks passed
jlaurens added a commit to jlaurens/latex2e that referenced this pull request Jun 6, 2024
* Tag new functions in lthooks.dtx

New functions were recently added. The online doc won't always reflect the actual distribution of the reader.
We tag the new functions as added to the 2023-06-01 release. This is not very pretty for L3 API because new and old functions are documented altogether. But this problem will disappear in a forthcoming release.

* `\lthooksdate` updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants