Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lthooks-code: less overfull box #1244

Merged
merged 3 commits into from
Jan 17, 2024

Conversation

jlaurens
Copy link
Contributor

@jlaurens jlaurens commented Jan 17, 2024

In order to improve the documentation, we do not want to add new warnings. This is why we try to remove as many of them. Some code has been reformatted by

  • line breaking
  • removing spaces
  • reseting the indentation
    Overfull hboxes essentially come from docstrip's <latexrelease> The documentation is not modified yet.

All checks passed.

Internal housekeeping

Status of pull request

  • Ready to merge

Checklist of required changes before merge will be approved

  • Test file(s) added
  • [X ] Version and date string updated in changed source files
  • Relevant \changes entries in source included
  • Relevant changes.txt updated
  • Rollback provided (if necessary)?
  • ltnewsX.tex (and/or latexchanges.tex) updated

Copy link
Member

@FrankMittelbach FrankMittelbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basically fine, thanks

base/lthooks.dtx Outdated Show resolved Hide resolved
@jlaurens jlaurens force-pushed the lthooks-less-overfull branch 4 times, most recently from 4b78809 to d27f1a2 Compare January 17, 2024 14:14
In order to improve the documentation, we do not want to add new
warnings. This is why we try to remove as many of them.
Some code has been reformatted by
- line breaking
- removing spaces
- reseting the indentation
Overfull hboxes essentially come from docstrip's `<latexrelease>`
The documentation is not modified yet.

Update lthooks.dtx

3947, 4138, 5809: no indent reset, replaced by line breaks
5785, 5812 semantic line breaking and format consistency
Copy link
Member

@FrankMittelbach FrankMittelbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe I should have found those first time around ... but anyway ... we like to add/keep more spaces in the code

base/lthooks.dtx Outdated Show resolved Hide resolved
base/lthooks.dtx Outdated Show resolved Hide resolved
base/lthooks.dtx Show resolved Hide resolved
base/lthooks.dtx Outdated Show resolved Hide resolved
base/lthooks.dtx Outdated Show resolved Hide resolved
base/lthooks.dtx Outdated Show resolved Hide resolved
base/lthooks.dtx Outdated Show resolved Hide resolved
base/lthooks.dtx Outdated Show resolved Hide resolved
base/lthooks.dtx Outdated Show resolved Hide resolved
@FrankMittelbach
Copy link
Member

thanks

@FrankMittelbach FrankMittelbach merged commit d7e284e into latex3:develop Jan 17, 2024
39 checks passed
@jlaurens jlaurens deleted the lthooks-less-overfull branch January 21, 2024 08:17
jlaurens added a commit to jlaurens/latex2e that referenced this pull request Jun 6, 2024
* lthooks-code: less overfull box

In order to improve the documentation, we do not want to add new
warnings. This is why we try to remove as many of them.
Some code has been reformatted by
- line breaking
- removing spaces
- reseting the indentation
Overfull hboxes essentially come from docstrip's `<latexrelease>`
The documentation is not modified yet.

Update lthooks.dtx

3947, 4138, 5809: no indent reset, replaced by line breaks
5785, 5812 semantic line breaking and format consistency

* Update lthooks.dtx

* Update lthooks.dtx

`///`→ `/ / / `
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants