Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1243 #1254

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Fix #1243 #1254

merged 3 commits into from
Jan 30, 2024

Conversation

jlaurens
Copy link
Contributor

@jlaurens jlaurens commented Jan 24, 2024 •
edited by FrankMittelbach
Loading

READ ME FIRST: Please understand that in most cases we will not be able to merge a pull request because there are a lot of internal activities needed when updating the LaTeX2e sources. If you have a code suggestion please discuss it with the team first.

Pull requests in this repository are intended for LaTeX Team members only.

2 commits for the review, but this should be rebased to 1

  1. adding 2 test files to demonstrate the bug.
  2. Fixing the bug and updating the tlg accordingly.

Internal housekeeping

Status of pull request

  • Ready to merge

Checklist of required changes before merge will be approved

  • Test file(s) added
  • Version and date string updated in changed source files
  • Relevant \changes entries in source included
  • Relevant changes.txt updated
  • Rollback provided (if necessary)?
  • ltnewsX.tex (and/or latexchanges.tex) updated

FrankMittelbach
FrankMittelbach approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@FrankMittelbach FrankMittelbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@FrankMittelbach FrankMittelbach merged commit aa691a7 into latex3:develop Jan 30, 2024
39 checks passed
jlaurens added a commit to jlaurens/latex2e that referenced this pull request Jun 6, 2024
@jlaurens
Fix latex3#1243 (latex3#1254)
5e78628 
* Test file to demonstrate the latex3#1243 issue

* Fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhelypeOleinik PhelypeOleinik PhelypeOleinik approved these changes

@FrankMittelbach FrankMittelbach FrankMittelbach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jlaurens @FrankMittelbach @PhelypeOleinik