Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for #1468 #1473

Merged
merged 3 commits into from
Oct 1, 2024
Merged

fix for #1468 #1473

merged 3 commits into from
Oct 1, 2024

Conversation

FrankMittelbach
Copy link
Member

@FrankMittelbach FrankMittelbach commented Sep 18, 2024 •
edited
Loading

Internal housekeeping

Status of pull request

  • Ready to merge

Checklist of required changes before merge will be approved

  • Test file(s) added
  • Version and date string updated in changed source files
  • Relevant \changes entries in source included
  • Relevant changes.txt updated
  • [n/a] Rollback provided (if necessary)?
  • ltnewsX.tex (and/or latexchanges.tex) updated

josephwright
josephwright approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@josephwright josephwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I've noted, we can address cell collection issues in collcell by talking to Martin, so I think we are good here

@FrankMittelbach
Copy link
Member Author

As I've noted, we can address cell collection issues in collcell by talking to Martin, so I think we are good here

@josephwright I leave that one on your plate then, since you said you wanted to talk to him anyway, okay?

@FrankMittelbach
Merge branch 'develop' into gh1468
9b9d5e2 
# Conflicts:
#	required/tools/changes.txt
@FrankMittelbach FrankMittelbach merged commit 4e696de into develop Oct 1, 2024
84 checks passed
@FrankMittelbach FrankMittelbach deleted the gh1468 branch October 1, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muzimuzhi muzimuzhi muzimuzhi left review comments

@davidcarlisle davidcarlisle davidcarlisle approved these changes

@josephwright josephwright josephwright approved these changes

@u-fischer u-fischer Awaiting requested review from u-fischer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FrankMittelbach @josephwright @davidcarlisle @muzimuzhi