Improve footnotes and adapt Ref to changes in tagpdf #1475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephwright
requested changes
Sep 25, 2024
|
All looks good except that |
FrankMittelbach
approved these changes
Sep 26, 2024
Comment on lines
+1977
to
+1978
| % test if a footnote is allowed, if not move up to the next sect or | ||
| % the document structure. |
There was a problem hiding this comment.
probably not as part of this PR but isn't that kind of somehting really common and we should have a command with some arguments that handle this situation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves tagging issue #714 and cleans up a few internals in the handling of Ref keys.
Status of pull request
Checklist of required changes before merge will be approved
\changesentries in source includedchanges.txtupdatedltnewsX.tex(and/orlatexchanges.tex) updated