Remove NonStruct from footnote label #1481
Conversation
| % \DescribeSocket[noprint]{tagsupport/fnmark} | ||
| % | ||
| % | ||
| % The socket is used in \cs{@footnotemark}/\cs{fnote_footnotemark:} | ||
| % and takes \cs{@makefnmark} as argument. It prints the mark in the text | ||
| % and surrounds it with a tagging structure and a link. As such it is | ||
| % not solely for tagging and so should not be used with \cs{UseTaggingSocket} | ||
| % as this would swallow the argument and loose the link support. | ||
| % |
There was a problem hiding this comment.
given the documentation the socket should not be "tagsupport/..." should it?
perhaps it should contain sockets that have the tagging stuff inside?
There was a problem hiding this comment.
Yes, I think one will have to rethink that. But I would suggest to leave that for after the november release and to improve now only the label tagging.
There was a problem hiding this comment.
ok fine, but then I think we should clearly state at the very top that the socket names as well as the suckets are likely to change because of that
There was a problem hiding this comment.
I added a comment and a Todo.
| % As it sets also the tl-var for the current structure and this is used | ||
| % in destinations it should not use as tagging socket. |
| % This socket handles mc-chunks around the text of the footnote. As it | ||
| % takes an argument (the text) is should not be use as tagging socket either. |
There was a problem hiding this comment.
I'll stop here, because I think this is a fundamental question that needs to be resolved first
Currently footnote labels contain a NonStruct element which was used as a helper structure to move the label to the begin of the footnote structure
with the new tagpdf this is no longer needed and with the change here the structure looks nice.
(The PR contains also a few docu changes and additions.)
Status of pull request
x Ready to merge
Checklist of required changes before merge will be approved
\changesentries in source includedchanges.txtupdatedltnewsX.tex(and/orlatexchanges.tex) updated