Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for "\={i}" to OT1 and T1 #1535

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Add support for "\={i}" to OT1 and T1 #1535

merged 1 commit into from
Nov 6, 2024

Conversation

josephwright
Copy link
Member

Internal housekeeping

Status of pull request

  • Feedback wanted
  • Under development
  • Ready to merge

Checklist of required changes before merge will be approved

  • Test file(s) added
  • Version and date string updated in changed source files
  • Relevant \changes entries in source included
  • Relevant changes.txt updated
  • Rollback provided (if necessary)?
  • ltnewsX.tex (and/or latexchanges.tex) updated

I'm not seeing a need for rollback here or a news entry as this is an edge case - but if I'm wrong, do say!

@josephwright josephwright linked an issue Nov 4, 2024 that may be closed by this pull request
Copy link
Member

@FrankMittelbach FrankMittelbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, but something fails in the source2e documentation

@josephwright
Copy link
Member Author

approved, but something fails in the source2e documentation

I'll look - I guess \changes

@josephwright
Copy link
Member Author

Ah, it's the = - suggested alternative to

% \changes{v2.1b}{2024/11/04}{Support \cs{=}\cs{i} for OT1}

?

@FrankMittelbach
Copy link
Member

Ah, it's the = - suggested alternative to

% \changes{v2.1b}{2024/11/04}{Support \cs{=}\cs{i} for OT1}

?

what is breaking there?

@josephwright
Copy link
Member Author

what is breaking there?

From source2e.gls:

  \item 2024-11-04 ltoutenc.dtx v2.1b\efill 
 \subitem General:\ }\cs {i} for T1\pfill \hdpindex{}{490}

@davidcarlisle
Copy link
Member

davidcarlisle commented Nov 5, 2024

gind.ist makes = the actual-char. \changes... support i-macron accent in OT1 would avoid falling over =

@FrankMittelbach
Copy link
Member

gind.ist makes = the actual-char. \changes... support i-macron accent in OT1 would avoid falling over =

ah, as simple as that. But I though macros are entred with quote chars in front of everything ...hmm, anyway, changing the text is certainly easy enough for now.

@josephwright
Copy link
Member Author

OK now?

@josephwright josephwright merged commit 36c9d14 into develop Nov 6, 2024
2 checks passed
@josephwright josephwright deleted the gh1453 branch November 6, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing composite command for “i with macron”
3 participants