Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce presence of <tool> name attribute #16

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Enforce presence of <tool> name attribute #16

merged 1 commit into from
Feb 10, 2025

Conversation

andresgutgon
Copy link
Contributor

What?

To allow consistency with what a tool request has (id and name) we want to enforce the presence of "name" attribute on tool responses tag

@andresgutgon andresgutgon marked this pull request as ready for review February 10, 2025 09:34
@andresgutgon
We need to enforce presence of <tool> name attribute
10a843d 
To allow consistency with what a tool request has (id and name) we want
to enforce the presence of "name" attribute on tool responses tag
@andresgutgon andresgutgon force-pushed the fix/enforce-presence-of-tool-name-attribute branch from f6f35fe to 10a843d Compare February 10, 2025 10:10
@andresgutgon andresgutgon merged commit 1ff406e into main Feb 10, 2025
2 checks passed
@andresgutgon andresgutgon deleted the fix/enforce-presence-of-tool-name-attribute branch February 10, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csansoon csansoon csansoon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andresgutgon @csansoon