-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make extendedGaugeResident
up to date with gaugePrecise
.
#1528
base: develop
Are you sure you want to change the base?
Make extendedGaugeResident
up to date with gaugePrecise
.
#1528
Conversation
…to date with `gaugePrecise`.
@weinbe2 can you test this with MILC when you get the chance please? |
cscs-ci run |
Finally testing this, sorry for the hold-up @SaltyChiang . This technically needs |
There's a small correctness issue somewhere that I'm seeing running MILC RHMC, namely the fermion contribution to the action at the very start of the evolution disagrees relative to I'll have to dig further into this and try to understand what's going awry... |
Thank you very much for the testing @weinbe2. I'll test the RHMC algorithm on my side. |
If you can take point on testing this with MILC RHM[C/D] for now, I would appreciate it @SaltyChiang , and if you remain stuck I'll loop back to it tomorrow (Thursday) my time, would that work? |
…xtended-gauge-resident
@SaltyChiang fyi I'm getting back to testing your PR with MILC RHM[C/D] today |
Okay it looks like everything is actually good @SaltyChiang . Can you re-merge in |
@weinbe2 I'm so sorry for taking so long to respond. I tested my HMC with HISQ yesterday but didn't see the difference on the delta H. I tried to configure the MILC code to check the issue but have not run it yet. You mean the issue disappears in your test with the current commit? |
@SaltyChiang yes, sorry, everything is good with the current commit, there was an issue in the way I was verifying things. If you're also seeing agreement in your HMC, it sounds like we're good from a correctness standpoint. I just kicked off the CI and, assuming there are no issues there, I will merge this today. |
@SaltyChiang you'll need to merge in the latest |
Update
extendedGaugeResident
ifgaugePrecise
is modified. I add a function to do the work. After this change, we should expect thatextendedGaugeResident
is always the extended version ofgaugePrecise
.Testings are required, hopefully CI/CD will do this for us.