Desktop: Resolves #11741: Accessibility: Add screen reader announcements when toggling the note list and/or sidebar #11776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the note list and/or sidebar
personalizedrefrigerator
changed the title
Comment on lines
+409
to
+410
| void window.webContents.executeJavaScript(`(() => { | ||
| const announcer = document.createElement('div'); |
There was a problem hiding this comment.
- I don't like this
.executeJavaScriptapproach — if feasible, switch to a different approach for creating announcements.
personalizedrefrigerator
added
desktop
Comment on lines
+34
to
+36
| shim.announceForAccessibility = (message) => { | ||
| AccessibilityInfo.announceForAccessibility(message); | ||
| }; |
There was a problem hiding this comment.
Currently, this implements shim.announceForAccessibility on Android and iOS, but not the web version of the mobile app.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request announces when the sidebar and note list are toggled. Previously, screen reader users had no indication that pressing F10 or F11 changed the app layout.
Related to #10795. Resolves #11741.
To-do
shim.. However, this method is currently only used on desktop (and unimplemented on web). A different approach (e.g. with a React context) might be better.