new: ✨ add ASGI middleware alternative

[thentgesMindee]

fix #98

Might be easier for people reviewing to explain the different commits:

• first commit adds the new ASGI middleware
• second one update tests so that it test both the HTTP and ASGI middlewares (using pytest parametrize and fixtures)
• third one is a refactoring commit, to avoid duplicating too much code between the HTTP and the ASGI middleware

Might be easier to first review the first two commits, then the refactoring one (to avoid seeing too many changes at once)

Let me know what do you think about this 😄

Note: maybe I could do a bit of refactoring between _inject_headers and _inject_asgi_headers as well ?

[laurentS]

Thanks for this PR @thentgesMindee ! Just to say I have no time to look into it this week (nor next, most likely), but there are other contributors to this repo who might get to it before then.

[thentgesMindee]

@laurentS alright thanks a lot for the information, no worries 😄
I see you enabled the github actions check on the branch and they fail because some changes were made on master and not rebased on my branch, gonna fix this right away

[thentgesMindee]

rebase made, + commit to update newly added tests
all checks should pass this time 😄

[laurentS]

Sorry for the delay in reviewing this. I suggested a few type annotations, hoping to at least get mypy to look into each function.
I think it'd be nice to give a minimal example of each usage in the docs as well, and maybe add a line explaining how you'd choose one or the other middleware.

[thentgesMindee]

Hi thanks for the review @laurentS !
I spotted a bug in my middleware, I'll fix it then handle your review requests

[thentgesMindee]

Just as an update, committed the fix I was talking about, as well as type annotations change requests.
will do some more commits either today or tomorrow for docstring and documentation 👌

[thentgesMindee]

Sorry for the delay, but I finally managed to find some time to:

• add support for both asynchronous or synchronous error handlers in the ASGI Middleware
• add a small documentation about choosing between ASGI and WSGI middleware
• some docstrings

Let me know what do you think about it

[thentgesMindee]

Hi @laurentS , sorry for being impatient, any chance you could review the requested changes ?
Don't want to rush you, just want to make sure this is not lost in time

[laurentS]

@thentgesMindee sorry for the lag. Things are a bit busy everywhere. I just approved the CI run, hadn't noticed this was waiting for a button click, and it failed on typing. Can you check and correct?

[thentgesMindee]

Sure no worries take your time, don't want to rush you, as I said I just wanted to make sure the PR wasn't forgotten.
Will have a look to the failure and ping you back when I resolve it

[thentgesMindee]

@laurentS type annotations were updated (just left a # type: ignore, but the other ones are fixed)

[thentgesMindee]

Just saw that the CI is still failing because of some unused imports, gonna fix it tomorrow!

[laurentS]

Looks good to me. Just a suggestion in _get_route_name to use a more modern style, otherwise all LGTM!

[thentgesMindee]

Thanks a lot for the review! rebased my branch to be up-to-date with current master, and added the last change about _get_route_name. All tests are passing.
Could you re-approve (can't approve my own PR, and seems that my force-push reset the old approvals) so that we merge this ?
Thanks again 🙏

[thentgesMindee]

Thanks a lot for the review! rebased my branch to be up-to-date with current master, and added the last change about _get_route_name. All tests are passing.
Could you re-approve (can't approve my own PR, and seems that my force-push reset the old approvals) so that we merge this ?
Thanks again 🙏