Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compiler warnings #446

Merged
merged 1 commit into from
Jan 21, 2024
Merged

Fix compiler warnings #446

merged 1 commit into from
Jan 21, 2024

Conversation

orgads
Copy link
Contributor

@orgads orgads commented Jan 17, 2024 •
edited
Loading

  • Remove pointless #define _GNU_SOURCE. It is already defined by gyp, and defining it after all the includes does nothing anyway.
  • unary minus operator applied to unsigned type, result still unsigned

@orgads orgads force-pushed the warnings branch 3 times, most recently from fbb878c to 60ebdaf Compare January 17, 2024 09:09
laverdet
laverdet reviewed Jan 19, 2024
View reviewed changes
src/external_copy/serializer_nortti.cc Outdated Show resolved Hide resolved
src/module/lib_handle.cc Outdated Show resolved Hide resolved
@orgads
Copy link
Contributor Author

orgads commented Jan 20, 2024

Rebased

@orgads
Fix compiler warnings
b501c42 
* Remove pointless #define _GNU_SOURCE. It is already defined by gyp,
  and defining it after all the includes does nothing anyway.
* unary minus operator applied to unsigned type, result still unsigned
@laverdet laverdet merged commit be71d25 into laverdet:main Jan 21, 2024
12 checks passed
@orgads orgads deleted the warnings branch January 21, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laverdet laverdet laverdet left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orgads @laverdet