Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prebuild to v13 #456

Merged
merged 1 commit into from
Feb 18, 2024
Merged

Update prebuild to v13 #456

merged 1 commit into from
Feb 18, 2024

Conversation

orgads
Copy link
Contributor

@orgads orgads commented Feb 13, 2024

This updates node-gyp dependency, and should fix the build on macos.

This updates node-gyp dependency, and should fix the build on macos.
@laverdet laverdet merged commit ac5fbde into laverdet:main Feb 18, 2024
12 checks passed
@orgads orgads deleted the prebuild-13 branch February 18, 2024 03:55
@baptisteArno
Copy link

@orgads @laverdet Why was that removed? It makes the package incompatible with Vercel deployment. (#477)

@orgads
Copy link
Contributor Author

orgads commented Jun 24, 2024

@baptisteArno Why was what removed? Suppose you mean pip install distutils, it was removed from github actions because the updated prebuild uses a newer node-gyp, which no longer needs this workaround. How is this related to Vercel?

@baptisteArno
Copy link

Suppose you mean pip install distutils

Yes sorry 🙏

When upgrading the package, the build on Vercel fails with error: No module named 'distutils'. But if I upgrade, It is supposed to use the updated prebuild you mention, right? Then I'm not sure what's wrong here 🤔

@orgads
Copy link
Contributor Author

orgads commented Jun 24, 2024

Then I guess you need to install distutils on vercel?

@laverdet
Copy link
Owner

@baptisteArno is just confused. The binaries for v4.8.0 were not uploaded because of a compilation issue. So if you rely on prebuilt binaries then you can't use that point release. GitHub actions are not invoked during npm install, my friend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants