Fix wrap content calculation by filter hidden views #280
Conversation
Sources/PinLayout+WrapContent.swift
Outdated
| let subviews: [PinView.PinView] | ||
| switch viewFilter { | ||
| case .visibleOnly: | ||
| subviews = view.subviews.filter { !$0.isHidden } |
There was a problem hiding this comment.
What about views with alpha = 0?
There is public visible(_ views: [UIView]) views filter that takes alpha into account -
PinLayout/Sources/Filters.swift
Line 25 in babea9c
There was a problem hiding this comment.
Good point, you could use the visible() here to filter views.
Sources/PinLayout+WrapContent.swift
Outdated
| } | ||
|
|
||
| private func wrapContent(_ type: WrapType, padding: PEdgeInsets, _ context: Context) -> PinLayout { | ||
| let subviews = view.subviews | ||
| private func wrapContent(_ type: WrapType, padding: PEdgeInsets, viewFilter: ViewFilter = .none, _ context: Context) -> PinLayout { |
There was a problem hiding this comment.
do we need default argument value (viewFilter = .none) in private function?
There was a problem hiding this comment.
Not needed here, the parameter should always be specified by callers
Sources/PinLayout+WrapContent.swift
Outdated
| let subviews: [PinView.PinView] | ||
| switch viewFilter { | ||
| case .visibleOnly: | ||
| subviews = view.subviews.filter { !$0.isHidden } |
There was a problem hiding this comment.
Good point, you could use the visible() here to filter views.
| @@ -33,6 +33,10 @@ extension NSView: Layoutable { | |||
| return PinLayout(view: self, keepTransform: false) | |||
| } | |||
|
|
|||
| public var isVisible: Bool { | |||
| !isHidden && alphaValue > 0 | |||
There was a problem hiding this comment.
| !isHidden && alphaValue > 0 | |
| return !isHidden && alphaValue > 0 |
| @@ -37,6 +37,10 @@ extension UIView: Layoutable, SizeCalculable { | |||
| return PinLayoutObjCImpl(view: self, keepTransform: true) | |||
| } | |||
|
|
|||
| public var isVisible: Bool { | |||
| !isHidden && alpha > 0 | |||
There was a problem hiding this comment.
| !isHidden && alpha > 0 | |
| return !isHidden && alpha > 0 |
|
bump |
Force rebuild
No description provided.