Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed install problems #2

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fixed install problems #2

wants to merge 6 commits into from

Conversation

clarkeadg
Copy link

I had problems installing this project because of grunt-phantomcss failing to install and because I was using a pc. I fixed the pc problems by renaming files with spaces. The grunt-phantomcss was fixed in a fork and I added the forked fix to the package.json. I also submitted a pull request for the fix to grunt-phantomcss.

@lazd
Copy link
Owner

lazd commented Jan 22, 2015

Thanks for looking into this!

I'm definitely down to merge this once your fix to grunt-phantomcss is merged and released!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 21.36% when pulling 43b0f29 on clarkeadg:master into a5a4701 on lazd:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 21.36% when pulling d640a04 on clarkeadg:master into a5a4701 on lazd:master.

@lazd
Copy link
Owner

lazd commented Mar 3, 2015

@clarkeadg has your fix to grunt-phantomcss been merged and released? If so, please update the PR to use the new version and let's merge this.

Thanks!

@clarkeadg
Copy link
Author

@lazd Nope, I don't think my PR has been looked at yet.

chrisgladd/grunt-phantomcss#36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants