This repository has been archived by the owner on May 14, 2024. It is now read-only.
Add Note on Client Error Handling to Documentation #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabianScheidt
changed the title
|
Please include a minimal reproducible example |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some people (including myself) attempt to use the LDAP client without registering a handler to the error event, since e.g. connection errors are supposed to be included in the callbacks of other methods. Since the client is an
EventEmitterhowever the Node.js process will exit if the handler is missing.This PR adds a note to the documentation to avoid confusion as suggested in #356 and #498.