Fix function pointers/delegates on Harvard architectures #4465
Conversation
Resolves issue ldc-developers#4432 by setting the address space of such IR pointers.
| { | ||
| foo(() {}, delegate() {}); | ||
|
|
||
| FP fp = &bar; |
There was a problem hiding this comment.
Probably good to also add testing of (normal) pointers to variables.
No IR test to validate that the address-space is correct? Or do we assume that is already part of LLVM checking?
There was a problem hiding this comment.
Yeah I was a bit lazy and wasn't sure how far we'd get with this. I've extended the test now, incl. storing and loading a function pointer in static data.
|
Great, thanks! I suggest a bit more stress-testing though: assigning a function pointer to a void pointer, pointer arithmetic and casting to/from an integral. |
Heh right, that's exactly what I don't expect to work yet ('not sure how far we'd get with this'). |
Understood 😄 . Function pointers/delegates aren't quite fixed though in that case. Granted, the original issue still is. One issue at a time is good way to work after all. |
Resolves issue #4432 by setting the address space of such IR pointers.