GH Actions: Export ~all symbols from prebuilt LTO'd macOS binaries #4468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JohanEngelen: Please let me know if you want to pursue a generic LTO solution or whether this would be good enough for now (modulo comments). I think fixing the exports on Mac is the only blocker for beta2. |
|
I think this is OK for now. I guess there are not many people building with LTO anyway. |
Fixes ldc-developers#4462 for our official packages.
kinke
changed the title
|
Feel free to add a further remark wherever you please if you didn't mean a YAML comment which I've just added. [I think the combo of using LTO, and needing plugin support, and on macOS is probably really rare. And I've quickly checked https://github.com/Homebrew/homebrew-core/blob/master/Formula/l/ldc.rb, no LTO being used there.] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4462 for our official packages.