feat(persisted-ops): Close both file and reader using defer

ldebruijn · Aug 9, 2024 · 227f01e · 227f01e
1 parent 110e0aa
commit 227f01e
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/internal/business/persistedoperations/gcp_storage_loader.go b/internal/business/persistedoperations/gcp_storage_loader.go
@@ -64,12 +64,13 @@ func (g *GcpStorageLoader) Load(ctx context.Context) error {
 	var errs []error
 	for {
 		attrs, err := it.Next()
-		numberOfFilesProcessed++
 
 		if errors.Is(err, iterator.Done) {
 			break
 		}
 		if err != nil {
+			// if any error is returned, any subsequent call returns the same error
+			// so we break here
 			errs = append(errs, err)
 			break
 		}