Rewrite persisted ops loader #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our initial strategy for loading persisted operations was flawed, mainly because of trying to use the local filesystem as a state store, requiring it to be consistent immediately after loading from a remote, and trying to read from local file storage right after.
This design was chosen in order to decouple local state from remote loading strategies, but this can be achieved in other ways.
This PR rewrites the loading behavior to use just the internal state in memory, and a loading strategy to append to it. This removes the dependency on the local file system for persisting this state, and simplifies the interactions for loading persisted operations.
Now, a single
loadercan be specified which currently arelocal, meaning files are read from the local file system.gcpmeaning files are downloaded from a GCP bucket and loaded straight into the internal state, ornoopmeaning no files are loaded.It also updates a number of metrics as well as the accompanying documentation