Draft changes for itemHandler #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raycoms
reviewed
Sep 27, 2024
|
@Raycoms this might probably do, but i havent tested it properly, also i have done nothing towards to double chest and alike Also this should be accompanied by changed during placement/pre-placement traversals do we require exactly once the content of BE |
Raycoms
reviewed
Oct 18, 2024
| @@ -264,6 +265,7 @@ public static boolean isWater(final BlockState iBlockState) | |||
| return iBlockState.getBlock() == Blocks.WATER; | |||
| } | |||
|
|
|||
| @Deprecated(forRemoval = true, since = "1.21") | |||
| private static Item getItem(final BlockState blockState) | |||
There was a problem hiding this comment.
we will still need solutions for this kind of things, don't just deprecate it =D
There was a problem hiding this comment.
It's in blockui for two version already
Raycoms
previously approved these changes
Oct 18, 2024
Nightenom
commented
Oct 20, 2024
| @@ -478,7 +478,7 @@ private void updateResources() | |||
| boolean handled = false; | |||
| for (final IPlacementHandler handler : PlacementHandlers.handlers) | |||
| { | |||
| if (handler.canHandle(world, BlockPos.ZERO, blockState)) | |||
There was a problem hiding this comment.
This was weird, especially no need to load world at zero during compute resources step
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Testing
Review please