scan tool fixes #719
Merged
scan tool fixes #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nightenom
approved these changes
Feb 8, 2025
| if (complete) | ||
| { | ||
| return Collections.singletonList(new ItemStack(blockState.getBlock())); | ||
| } | ||
| return new ArrayList<>(); |
There was a problem hiding this comment.
shouldn't this always be the block?
There was a problem hiding this comment.
No, this is when the world block matches
| @@ -553,6 +553,7 @@ else if (item instanceof BlockItem) | |||
| // place | |||
| world.setBlock(here, Blocks.COBBLESTONE.defaultBlockState(), Block.UPDATE_CLIENTS); | |||
| world.setBlock(here, newState, Constants.UPDATE_FLAG); | |||
| world.getBlockEntity(here).applyComponentsFromItemStack(stackToPlace); | |||
| targetBlock.setPlacedBy(world, here, newState, fakePlayer, stackToPlace); | |||
There was a problem hiding this comment.
this entire branch should honestly use just the Item#useOn(...), wonder if it is even safe these days to perform blockentity-ignore blockstate update, w/e for now
There was a problem hiding this comment.
It's not so easy to even use-on without messy blockstates =D
Raycoms
added a commit
that referenced
this pull request
Feb 9, 2025
Fix slab/domum handling and water handling and grass/dirt path handling and stairs handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Closes #
Changes proposed in this pull request
Testing
Review please