Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve armor distribution, make use of attribute modifiers #10667

Open
wants to merge 1 commit into
base: version/main
Choose a base branch
from

Conversation

Thodor12
Copy link
Contributor

Changes proposed in this pull request

  • No longer use ArmorMaterial to calculate the armor level, not all armors provide a full set, giving wrong indications of armor level
  • Vanilla armor is forced into levels 1-5
  • Non-vanilla armor it's armor level is deteremined, then compared against leather - chainmail - iron - diamond in that exact order for the same armor items, giving an indication of where the armor should fit in the list
  • Armor and toughness are calculated from an itemstack directly, taking attribute modifiers into account, hopefully to resolve Does not wear Tinkers armor' Construct #10586

Testing

  • Yes I tested this before submitting it.
  • I also did a multiplayer test.

Review please

…re distributed along the relative value of the armor compared to a similar slot of leather/chainmail/iron/diamond
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not wear Tinkers armor' Construct
2 participants