Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unnecessary item handler invalidation #10677

Open
wants to merge 8 commits into
base: version/1.21
Choose a base branch
from
Open

Fix unnecessary item handler invalidation #10677

wants to merge 8 commits into from

Conversation

Thodor12
Copy link
Contributor

Closes #10671
Closes #10670

Changes proposed in this pull request

  • Move container removal to onColonyTick in the building
  • Item handler capability will only be recalculated if the underlying container list has changed
  • Removed obsolete code in CombinedItemHandler (the nameable has no effect, nor any usages)

Testing

  • Yes I tested this before submitting it.
  • I also did a multiplayer test.

Review please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Thodor12