Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information for uploadToItch.md #235

Merged
merged 4 commits into from
Dec 18, 2023
Merged

Conversation

vaasut
Copy link
Contributor

@vaasut vaasut commented Nov 3, 2023

Description

This page was a stub. I added some information on how to upload a game to itch.io

seleb
seleb previously approved these changes Nov 3, 2023
Copy link
Collaborator

@seleb seleb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple little formatting fixes but otherwise looks good to me!

docs/docs/faq/uploadToItch.md Outdated Show resolved Hide resolved
docs/docs/faq/uploadToItch.md Outdated Show resolved Hide resolved
vaasut and others added 3 commits November 7, 2023 11:32
Fix React Syntax Error : Expected corresponding JSX closing tag for <img>
@le-doux le-doux changed the base branch from main to version-8-8 December 18, 2023 22:53
@le-doux
Copy link
Owner

le-doux commented Dec 18, 2023

looks like a great addition - thank you @vaasut! thanks for the review and edits @seleb!

@le-doux le-doux merged commit 8f54a06 into le-doux:version-8-8 Dec 18, 2023
1 check passed
le-doux added a commit that referenced this pull request Dec 19, 2023
* Add information for uploadToItch.md (#235)

* Add information for uploadToItch.md

* Update docs/docs/faq/uploadToItch.md

Co-authored-by: Sean S. LeBlanc <[email protected]>

* Fix typos in docs/docs/faq/uploadToItch.md

Co-authored-by: Sean S. LeBlanc <[email protected]>

* Add closing tag for <img> to uploadToItch.md

Fix React Syntax Error : Expected corresponding JSX closing tag for <img>

---------

Co-authored-by: Sean S. LeBlanc <[email protected]>

* fix ClearCache tile memory leak (#232)

* fix off-by-one allocating

given these blocks:

4: occupied
5: occupied
6: undefined

and this call:
`_allocate({ start: 4, max: 2 })`

you would expect the allocation to fail and return null.
before this commit, this situation instead would allocate block 6

I don't know if this had any adverse effects; I just noticed it while
working on related stuff

* make sure ClearCache() deletes tile memory

fixes #230

* fix: Duplicate room button does not copy everything #185 (#228)

* fix: Duplicate room button does not copy everything #185

* use copied items array instead of slice

---------

Co-authored-by: Adam Le Doux <[email protected]>

* brazilian portuguese translation

---------

Co-authored-by: vaasut <[email protected]>
Co-authored-by: Sean S. LeBlanc <[email protected]>
Co-authored-by: pancelor <[email protected]>
Co-authored-by: fran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants