Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(glide-bundle): change routing file extension from .yml to .yaml #32

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

lucasmirloup
Copy link
Member

Symfony\Routing\Loader\YamlFileLoader supporte depuis 2015 les fichiers .yaml (en plus de .yml) : https://github.com/symfony/symfony/blame/f00b3279ea874dcbd9132cabb2f5d4900c3716ea/src/Symfony/Component/Routing/Loader/YamlFileLoader.php#L108

Depuis quelques années, Symfony charge tous les fichiers contenus dans le sous-dossier routes du dossier de config.
Le code responsable de ce comportement était dans les recettes Flex de Symfony : https://github.com/symfony/recipes/blob/f7b01cec173d58363a236a3cff0bc98e34506ac0/symfony/framework-bundle/4.4/src/Kernel.php#L51

En Symfony 5.1, cette recette a été modifiée pour ne supporter que l'extension .yaml par défaut : https://github.com/symfony/recipes/blob/f7b01cec173d58363a236a3cff0bc98e34506ac0/symfony/framework-bundle/5.1/src/Kernel.php#L30

Ce code a depuis été déplacé dans le MicroKernelTrait, directement dans Symfony : https://github.com/symfony/symfony/blob/bce54929ef12d644cba84073fa47e2d263f27f79/src/Symfony/Bundle/FrameworkBundle/Kernel/MicroKernelTrait.php#L79

@lucasmirloup lucasmirloup requested a review from thislg November 27, 2023 14:09
@lucasmirloup lucasmirloup self-assigned this Nov 27, 2023
@thislg thislg merged commit dfc79c0 into main Nov 27, 2023
@thislg thislg deleted the fix/glide-bundle-routing-yaml-extension branch November 27, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants