Exit with a non-zero exit status if a given mail does not exist #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hacked this together rather quickly, let me know if you think it is worthwhile to peruse this approach further or if you prefer an alternative design. |
|
I think it should keep going, anyway (compare cp(1) e.g.) As only mscan and mpick use the count for informative messages, perhaps we could count in the callback instead... |
nmeum
force-pushed
the
mblaze-error-handling
branch
from
900863b to
89e7d05
Compare
Good idea, updated accordingly. Let me know what you think |
Callers which need the number of messages processed need to count in the callback function now, see the previous commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sadly, the diff is quite large as we will have to change the API of
blaze822_loopto differentiate the number of processed messages and a status code indicating a missing mail. Note that currently execution is not aborted upon encountering the first non-existent mail; hence, we can't do both via the return value.Surprisingly, very few utilities actually use the number of processed messages as returned by
blaze822_loop. Therefore, we could reduce the diff quite a bit by differentiating the two use cases through separate functions (e.g.blaze822_loopandblaze822_loop_num), which would allow the API of blaze822_loop to remain largely unchanged.The new
blaze822_loopAPI would also allow us to improve error handling forblaze822_seq_nextbut I haven't done this so far…There are also some tests, but these should be expanded.
Fixes #264