xlint: check for multiline variable set #266
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it's correct. Empty lines in multi-line variables are confusing. |
|
have you tried running this on all srcpkgs? ( I found that useful to find issues with my attempt at this |
The continuation lines should start with a single space
tornaria
force-pushed
the
xlint_check_multiline
branch
from
e3119b4 to
ebac483
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The continuation lines should start with a single space.
I wrote this months ago, but I forgot to PR.
I think it works ok, it's matching quotes (" vs '). In the continuation lines, it complains unless the line starts with a single space followed by not-a-[:space:]. In particular, as this is written, a single space in a line by itself is forbidden. In effect this means one cannot have an empty line in a multiline variable set. Let me know if that's incorrect (and if so, what's allowed for that).