Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump min sdk to 3.5.0 in all packages #2371

Merged
merged 12 commits into from
Oct 17, 2024
Merged

Bump min sdk to 3.5.0 in all packages #2371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e7dadba
Bump min sdk to 3.5.0 across packages
Oct 14, 2024
32a3132
Add check-semver workflow for patrol_finders
Oct 14, 2024
86ccf61
Bump Flutter and Dart version in workflows
Oct 14, 2024
43f1525
Adjust to new linter rules in patrol_finders package
Oct 14, 2024
f8e424f
Adjust to new linter rules in patrol_cli package
Oct 14, 2024
1de1ed5
Fix analyzer issues in package adb
Oct 15, 2024
85993ab
Adjust to new linter rules in patrol package
Oct 15, 2024
6c92ca5
Replace deprecated onPopInvoked parameter
Oct 15, 2024
ea3fded
Use Flutter 3.24 in patrol develop tests
Oct 15, 2024
53aca2c
Bump leancode_lint to 14.2.0
Oct 16, 2024
d7da267
Bump dependecies
Oct 16, 2024
dd5bdc8
Fix patrol_cli tests
Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .cirrus.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ test_linux_task:
kvm: "true"
env:
PATH: $HOME/.pub-cache/bin:$HOME/fvm/default/bin:$CIRRUS_WORKING_DIR/fvm:${PATH}
FLUTTER_VERSION: "3.22.0"
FLUTTER_VERSION: "3.24.0"
EMULATOR_API_LEVEL: "34"
EMULATOR_ABI: google_apis_playstore;x86_64
EMULATOR_IMAGE: system-images;android-${EMULATOR_API_LEVEL};${EMULATOR_ABI}
Expand Down Expand Up @@ -66,7 +66,7 @@ test_macos_task:
image: ghcr.io/cirruslabs/macos-sonoma-xcode:latest
env:
PATH: $HOME/.pub-cache/bin:$HOME/fvm/default/bin:${PATH}
FLUTTER_VERSION: "3.22.0"
FLUTTER_VERSION: "3.24.0"
timeout_in: 30m

set_up_fvm_script: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/adb-prepare.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
strategy:
fail-fast: false
matrix:
dart-version: ['3.3']
dart-version: ['3.5']

defaults:
run:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/check-semver.yaml → .github/workflows/patrol-check-semver.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: check semver
name: patrol check semver

on:
workflow_dispatch:
Expand Down Expand Up @@ -37,7 +37,7 @@ jobs:
channel: ${{ matrix.flutter-channel }}

- name: Install dart-apitool
run: dart pub global activate dart_apitool
run: dart pub global activate dart_apitool 0.19.0

- name: Check API changes
run: |
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/patrol-prepare.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
fail-fast: false
matrix:
os: [windows-latest]
flutter-version: ['3.22.x']
flutter-version: ['3.24.x']
flutter-channel: ['stable']

defaults:
Expand Down Expand Up @@ -65,7 +65,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest]
flutter-version: ['3.22.x']
flutter-version: ['3.24.x']
flutter-channel: ['stable']

defaults:
Expand Down Expand Up @@ -133,7 +133,7 @@ jobs:
fail-fast: false
matrix:
os: [macos-13]
flutter-version: ['3.22.x']
flutter-version: ['3.24.x']
flutter-channel: ['stable']

defaults:
Expand Down Expand Up @@ -173,7 +173,7 @@ jobs:
strategy:
fail-fast: false
matrix:
flutter-version: ['3.22.x']
flutter-version: ['3.24.x']
flutter-channel: ['stable']

defaults:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/patrol-publish.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:

strategy:
matrix:
flutter-version: ['3.22.x']
flutter-version: ['3.24.x']
flutter-channel: ['stable']

steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/patrol_cli-prepare.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-latest]
flutter-version: ['3.22.x']
flutter-version: ['3.24.x']
flutter-channel: ['stable']

defaults:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/patrol_devtools_extension-prepare.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
strategy:
fail-fast: false
matrix:
flutter-version: ['3.22.x']
flutter-version: ['3.24.x']
flutter-channel: ['stable']

defaults:
Expand Down
46 changes: 46 additions & 0 deletions .github/workflows/patrol_finders-check-semver.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
name: patrol_finders check semver

on:
workflow_dispatch:
pull_request:
paths:
- 'packages/patrol_finders/**'

jobs:
check_semver:
name: Check semver
runs-on: ubuntu-latest

strategy:
fail-fast: false
matrix:
flutter-version: ['3.24.x']
flutter-channel: ['stable']

steps:
- name: Clone repository
uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Get last released version
id: get_last_released_version
run: |
last_version=$(git tag --list 'patrol_finders-v*' | grep -v '\-dev\.[0-9]\+$' | sort -V | tail -n 1 | sed 's/^patrol_finders-v//')
echo "last_version=$last_version" >> $GITHUB_ENV
echo "::set-output name=last_version::$last_version"

- name: Set up Flutter
uses: subosito/flutter-action@v2
with:
flutter-version: ${{ matrix.flutter-version }}
channel: ${{ matrix.flutter-channel }}

- name: Install dart-apitool
run: dart pub global activate dart_apitool 0.19.0

- name: Check API changes
run: |
dart-apitool diff \
--old pub://patrol_finders/${{ steps.get_last_released_version.outputs.last_version }} \
--new packages/patrol_finders
2 changes: 1 addition & 1 deletion .github/workflows/patrol_finders-prepare.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
strategy:
fail-fast: false
matrix:
flutter-version: ['3.22.x']
flutter-version: ['3.24.x']
flutter-channel: ['stable']

defaults:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/patrol_finders-publish.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:

strategy:
matrix:
flutter-version: ['3.22.x']
flutter-version: ['3.24.x']
flutter-channel: ['stable']

steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/patrol_gen-prepare.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
strategy:
fail-fast: false
matrix:
dart-version: ['3.3']
dart-version: ['3.5']

defaults:
run:
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/prepare-e2e_app.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
fail-fast: false
matrix:
os: [windows-latest]
flutter-version: ['3.22.x']
flutter-version: ['3.24.x']
flutter-channel: ['stable']

defaults:
Expand Down Expand Up @@ -66,7 +66,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest]
flutter-version: ['3.22.x']
flutter-version: ['3.24.x']
flutter-channel: ['stable']

defaults:
Expand Down Expand Up @@ -121,7 +121,7 @@ jobs:
fail-fast: false
matrix:
os: [macos-13]
flutter-version: ['3.22.x']
flutter-version: ['3.24.x']
flutter-channel: ['stable']

defaults:
Expand Down Expand Up @@ -193,7 +193,7 @@ jobs:
strategy:
fail-fast: false
matrix:
flutter-version: ['3.22.x']
flutter-version: ['3.24.x']
flutter-channel: ['stable']

defaults:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-android-device.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
strategy:
fail-fast: false
matrix:
flutter-version: ['3.22.x']
flutter-version: ['3.24.x']
flutter-channel: ['stable']
os: ['Android API']
include:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-ios-device.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
strategy:
fail-fast: false
matrix:
flutter-version: ['3.22.x']
flutter-version: ['3.24.x']
flutter-channel: ['stable']
device_model: ['iphone14pro']
os_version: ['16.6']
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-ios-simulator-webview.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
strategy:
fail-fast: false
matrix:
flutter-version: ["3.22.x"]
flutter-version: ["3.24.x"]
flutter-channel: ["stable"]
device_model: [iPhone 14]
os: [iOS]
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-ios-simulator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
strategy:
fail-fast: false
matrix:
flutter-version: ["3.22.x"]
flutter-version: ["3.24.x"]
flutter-channel: ["stable"]
device_model:
[iPhone SE (3rd generation), iPhone 14, iPad (10th generation)]
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-macos.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
strategy:
fail-fast: false
matrix:
flutter-version: ['3.22.x']
flutter-version: ['3.24.x']
flutter-channel: ['stable']
device_model: [macOS]
os: [macOS]
Expand Down
4 changes: 2 additions & 2 deletions dev/cli_tests/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@ name: cli_tests
description: Scripts to test patrol_cli.

environment:
sdk: '>=3.2.0 <4.0.0'
sdk: '>=3.5.0 <4.0.0'

dependencies:
path: ^1.8.3

dev_dependencies:
leancode_lint: ^12.1.0
leancode_lint: ^14.2.0
3 changes: 3 additions & 0 deletions dev/e2e_app/lib/main.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,9 @@ class _ExampleHomePageState extends State<ExampleHomePage> {
@override
Widget build(BuildContext context) {
_appLinks.uriLinkStream.listen((uri) {
if (!context.mounted) {
return;
}
Navigator.of(context).push(
MaterialPageRoute<void>(
builder: (_) => ApplinkScreen(
Expand Down
Loading
Loading