Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The above error occurs because of two issues:
Exception::allocator
global present in the wasm libs, the initialization of which was done by pre-executor before, but now fails because the pre-executor does not handle a threading intrinsic.Because of these issues, any WASI program with globals that could not be pre-executed would fail with the above error. This PR fixes both issues. Note that no changes are made to pre-executor, it will still fail to initialize some gloals due to unhandled intrinsics. But this will no longer be a problem as, with these fixes, they can now be initialized at runtime in WASI.