Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated JNLP runner docs for new release #210

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

theodoravraimakis
Copy link
Contributor

No description provided.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is important to explain at the beginning of this guide that there are two ways to do the license activation and that they are mutually exclusive. Then direct the user to the section that they need to follow. Otherwise they may think it is required to do both methods.

@epanholz
Copy link
Member

epanholz commented Feb 3, 2025

We might need to retake some of the screenshots after I am done reviewing the actual extension code. There is some code changes I requested that might change the look of the extension.
Please wait with merging it after you are done with your review @GabrielaReyna We also need to wait for the extension to be final and in the store.

Comment on lines +34 to +39
Activate your license key
<a
href="chrome-extension://aklbimhnkloeefmeobindhkbpncelbmg/license.html"
target="_blank"
class="text-white hover:text-gray-300 font-bold">here.</a
>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Careful here, the url points to a local installation of the JNLPRunner and not the version in the webstore. In general I don't think it's a smart idea to link to an extension page like this. We could say something like, enter the key in the "manage license" section of the installed JNLPRunner extension and also link to the docs that explain how to activate a license.

</p>
</div>
<div class="w-1/2 p-4 box-border">
<!-- <iframe class="w-full h-[600px] border-none" src={formUrl}> </iframe> -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment can be removed.

Comment on lines +6 to +12
This tutorial will guide you on the basic functionalities of the JNLP Runner extension. We assume you have installed the extension on [Chrome](/cheerpj-jnlp-runner/getting-started/install-chrome) or [Edge](/cheerpj-jnlp-runner/getting-started/install-edge).

### Before using the extension

The first time you launch a JNLP file to run a Java application, the JNLP Runner will automatically detect it and it will start running. The first screen you will see is the license agreement. Please read this carefully and if you agree with the terms and conditions, click on _**Accept license**_.

<div class="mx-24">![](/assets/jnlp-screenshots/license_agreement.png)</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also link to the actual license here -> https://cheerpj.com/cheerpj-jnlp-runner-end-user-licence-agreement/

Comment on lines +20 to +23
### Manage license button

Click on this button to activate your license key or token. For more information, check the [Activate your license](/cheerpj-jnlp-runner/getting-started/activate-license) tutorial.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change the wording of button to link, since it currently does not really look like a button.
The url to activate-license does not work, I think the file is currently just called licensing

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the end of the licensing part we should also link to the licensing agreement -> https://cheerpj.com/cheerpj-jnlp-runner-end-user-licence-agreement/
We also do that in the CheerpX docs like this:
For any doubt, please check the [Complete License](https://cheerpj.com/cheerpj-jnlp-runner-end-user-licence-agreement/).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also add a section on the popup and that you can drag and drop a jnlp file there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants