-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore(Polynomial/*): avoid simp lemma that introduces Nat subtraction #11316
Conversation
jcommelin
commented
Mar 12, 2024
PR summary 62ab752f9cImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit> The doc-module for No changes to technical debt.You can run this locally as
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I checked that the n = 0
cases are indeed still simplified correctly.)
Is there a specific example you can point to that gets a clear improvement? Or is it more of a general principle to avoid nat subtraction?
I suppose either way I'm not going to oppose this change, it makes simp
slightly less powerful but it doesn't actually seem to have that big of an impact overall.
bors r+
Pull request successfully merged into master. Build succeeded: |