Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(Polynomial/*): avoid simp lemma that introduces Nat subtraction #11316

Closed
wants to merge 8 commits into from

Conversation

jcommelin
Copy link
Member


Open in Gitpod

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Mar 21, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Mar 28, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Apr 5, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Apr 19, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 19, 2024
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 11, 2025
Copy link

github-actions bot commented Feb 11, 2025

PR summary 62ab752f9c

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ derivative_X_pow_succ
+ derivative_monomial_succ

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@jcommelin jcommelin changed the title chore(Polynomial/*): various cleanups chore(Polynomial/*): avoid simp lemma that introduces Nat subtraction Feb 12, 2025
Copy link
Contributor

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I checked that the n = 0 cases are indeed still simplified correctly.)

Is there a specific example you can point to that gets a clear improvement? Or is it more of a general principle to avoid nat subtraction?

I suppose either way I'm not going to oppose this change, it makes simp slightly less powerful but it doesn't actually seem to have that big of an impact overall.

bors r+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 13, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Polynomial/*): avoid simp lemma that introduces Nat subtraction [Merged by Bors] - chore(Polynomial/*): avoid simp lemma that introduces Nat subtraction Feb 13, 2025
@mathlib-bors mathlib-bors bot closed this Feb 13, 2025
@mathlib-bors mathlib-bors bot deleted the jmc-cleanup-polynomial branch February 13, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants