Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(Probability): notation and lemmas for the composition of a measure and a kernel (Measure.bind) #19639

Closed
wants to merge 26 commits into from

Conversation

RemyDegenne
Copy link
Contributor

@RemyDegenne RemyDegenne commented Nov 30, 2024

From the TestingLowerBounds project.
Co-authored-by: Lorenzo Luccioli


Open in Gitpod

@RemyDegenne RemyDegenne added WIP Work in progress t-measure-probability Measure theory / Probability theory labels Nov 30, 2024
Copy link

github-actions bot commented Nov 30, 2024

PR summary afeec6a9e6

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Probability.Kernel.Proper 1
Mathlib.Probability.Kernel.Composition.CompNotation (new file) 1403
Mathlib.Probability.Kernel.Composition.MeasureComp (new file) 2001
Mathlib.Probability.Kernel.Composition.Lemmas (new file) 2003

Declarations diff

+ AbsolutelyContinuous.comp
+ AbsolutelyContinuous.comp_left
+ AbsolutelyContinuous.comp_right
+ IsProper.setLIntegral_eq_comp
+ MeasureTheory.Measure.parallelComp_comp_compProd
+ add_comp
+ add_comp'
+ compProd_eq_comp_prod
+ compProd_eq_parallelComp_comp_copy_comp
+ compProd_id
+ compProd_id_eq_copy_comp
+ comp_add
+ comp_apply_univ
+ comp_assoc
+ comp_smul
+ const_comp
+ deterministic_comp_eq_map
+ fst.instIsZeroOrProbabilityMeasure
+ id_comp
+ instance [IsFiniteMeasure μ] [IsFiniteKernel κ] : IsFiniteMeasure (κ ∘ₘ μ) := by
+ instance [IsProbabilityMeasure μ] [IsMarkovKernel κ] : IsProbabilityMeasure (κ ∘ₘ μ) := by
+ instance [SFinite μ] [IsSFiniteKernel κ] : SFinite (κ ∘ₘ μ) := by
+ map_comp
+ parallelComp_comm
+ parallelComp_comp_parallelComp
+ parallelComp_comp_prod
+ parallelComp_id_left_comp_parallelComp
+ parallelComp_id_right_comp_parallelComp
+ prod_comp_left
+ prod_comp_right
+ snd.instIsZeroOrProbabilityMeasure
+ snd_compProd
+ swap_comp
++ instance [IsZeroOrProbabilityMeasure μ] [IsZeroOrMarkovKernel κ] :

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Nov 30, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 5, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 8, 2024
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Dec 11, 2024
@mathlib4-dependent-issues-bot
Copy link
Collaborator

This PR/issue depends on:

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 11, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 21, 2024
@RemyDegenne RemyDegenne removed the WIP Work in progress label Jan 16, 2025
Copy link
Contributor

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@sgouezel sgouezel added the awaiting-author A reviewer has asked the author a question or requested changes label Jan 21, 2025
@RemyDegenne
Copy link
Contributor Author

I created a new file for the notation to be able to import it elsewhere more easily.

@RemyDegenne RemyDegenne removed the awaiting-author A reviewer has asked the author a question or requested changes label Jan 24, 2025
@RemyDegenne
Copy link
Contributor Author

lake exe shake was not happy because the Proper file imported CompNotation only for a notation, so I ran lake exe shake --update to add an exception.

Copy link
Contributor

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+
Thanks!

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 28, 2025

✌️ RemyDegenne can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@RemyDegenne
Copy link
Contributor Author

bors r+

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Jan 28, 2025
mathlib-bors bot pushed a commit that referenced this pull request Jan 28, 2025
…re and a kernel (Measure.bind) (#19639)

From the TestingLowerBounds project.
Co-authored-by: Lorenzo Luccioli



Co-authored-by: Remy Degenne <[email protected]>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 28, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Probability): notation and lemmas for the composition of a measure and a kernel (Measure.bind) [Merged by Bors] - feat(Probability): notation and lemmas for the composition of a measure and a kernel (Measure.bind) Jan 28, 2025
@mathlib-bors mathlib-bors bot closed this Jan 28, 2025
@mathlib-bors mathlib-bors bot deleted the RD_comp branch January 28, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated ready-to-merge This PR has been sent to bors. t-measure-probability Measure theory / Probability theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants