-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Data/List/Basic): split take
and drop
from file
#21232
base: master
Are you sure you want to change the base?
Conversation
PR summary 848261948d
|
File | Base Count | Head Count | Change |
---|---|---|---|
Mathlib.Data.Array.Lemmas | 366 | 362 | -4 (-1.09%) |
Import changes for all files
Files | Import difference |
---|---|
There are 4102 files with changed transitive imports taking up over 178422 characters: this is too many to display! | |
You can run scripts/import_trans_difference.sh all locally to see the whole output. |
Declarations diff
+ splitAt_eq_take_drop
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>
The doc-module for script/declarations_diff.sh
contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relative
value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolute
value is therelative
value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
Co-authored-by: Ruben Van de Velde <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work overall, the split makes sense although it's unfortunate it only ends up reducing the total number of lines by 10%. We still have some work to do!
A couple suggestions to improve the import graph even more.
Co-authored-by: Anne Baanen <[email protected]>
Co-authored-by: Anne Baanen <[email protected]>
Co-authored-by: Anne Baanen <[email protected]>
…ommunity/mathlib4 into BoltonBailey/split-takedrop
take
and drop
from filetake
and drop
from file
This will collide with #21530 Frankly, that PR is much more extensive splitting and should be reviewed and merged first, possibly this PR can just be closed if so. |
I didn't touch |
I've merged master now, it will at least need a |
bors d+ |
✌️ BoltonBailey can now approve this pull request. To approve and merge a pull request, simply reply with |
This PR splits
Data/List/Basic.lean
decls and lemmas related totake
ordrop
into a newTakeDrop.lean
file, decreasing the length of a file triggering the long file linter.