feat: socket support using LibUV #6683
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Henrik Böving <[email protected]>
This PR adds support for `Timer` and a event loop thread that gets requests from another threads and executes it. --------- Co-authored-by: Markus Himmel <[email protected]> Co-authored-by: Henrik Böving <[email protected]>
This PR implements a basic asynchronous timer API on top of the libuv work. It purposely puts this into `Std.Internal` as we might still have to change the API as we continue develop of the async library across releases so I would only like to stabilize it once we are certain this is a fine API. A few additional notes: - we currently do not implement a bind operator on `AsyncTask` on purpose as `Task.bind` on `Task.pure` is a non trivial operation and users should be aware of it. Furthermore there is the consideration that as they will have to bind on both `IO` and `AsyncTask` we might want to make potential task points explicit in the syntax (did somebody say `await`?). - the API generally takes inspiration from https://docs.rs/tokio/latest/tokio/time/index.html, though it has to adapt as Rust's and Lean's asynchronity concepts are sufficiently different. Stacked on top of leanprover#6219.
m# git update-ref -d MERGE_HEAD
hargoniX
requested changes
Jan 20, 2025
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
hargoniX
requested changes
Jan 23, 2025
There was a problem hiding this comment.
I think this is very promising now! There's mostly on memory leaks and stylistic things left but the implementation looks like it should be able to work now.
Beyond these issues it would of course be great if we could also have some tests like for Timer that exercise this API. I would assume you can just connect to localhost and do an echo or something like that? Of course we should have tests for both IPv4 and v6.
After we have those tests I guess it might also be a good idea to write a little benchmark to see how many TCP connections we can handle per second to get an estimate of what kind of load we can expect to handle at best given this implementation.
algebraic-dev
changed the title
algebraic-dev
changed the title
hargoniX
requested changes
Feb 26, 2025
There was a problem hiding this comment.
I only did a surface level review of the UDP code and in depth for the TCP one as there is already so much stuff in this PR. Maybe we could split the UDP out of the PR and focus on getting TCP working first, then merge UDP in a second one?
Beyond the remarks left I think two important things to consider are:
- we should be consistent style wise, both with things like
sockaddrvsstruct sockaddras well as the pointer star etc. - Given that there is non trivial invariants at play here it might help to add more debug assertions that we can enable in order to trace bugs in the wild should we miss something in the review here
src/Std/Internal/Async/UDP.lean
Outdated
| Sets the membership for joining or leaving a multicast group. | ||
| -/ | ||
| @[inline] | ||
| def setMembership (s : Socket) (multicastAddr : String) (interfaceAddr : String) (membership : Internal.UV.UDP.Membership) : IO Unit := |
There was a problem hiding this comment.
Another interesting question here is where multicastAddr and interfaceAddr are even going to come from? We don't have API to play with interfaces right?
Co-authored-by: Henrik Böving <[email protected]>
|
I have removed most of the UDP related code for now and I will create another PR once this one is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces TCP and UDP socket support using the LibUV library, enabling asynchronous I/O operations with it.