feat: customizable occurrence highlighting #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like the Windows CI failure is a repo-wide issue rather than something from this PR in particular, but I don't have a Windows machine handy to manually test on. |
|
No worries, the tests are somewhat flaky. |
mhuisi
reviewed
Dec 22, 2023
david-christiansen
force-pushed
the
toggleable-text-highlight-v2
branch
from
e4ce8b8 to
8bf7ee2
Compare
Makes it possible to disable substring-based occurrence highlighting and use only Lean's compiler responses.
david-christiansen
force-pushed
the
toggleable-text-highlight-v2
branch
from
8bf7ee2 to
834c888
Compare
|
Thanks for the feedback! |
mhuisi
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it possible to disable substring-based occurrence highlighting and use only Lean's compiler responses.
This is an alternative version of #371 that simplifies the settings interface on the assumption that everyone wants the correct highlights. @mhuisi - this is what we talked about the other day.