Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: abbreviate average: ⨍, -int: ⨍, oiint: ∯, tint: ∯, pd: ∂ #387

Merged
merged 3 commits into from
Jan 17, 2024

Conversation

girving
Copy link
Contributor

@girving girving commented Jan 12, 2024

@girving
Copy link
Contributor Author

girving commented Jan 12, 2024

Unfortunately I am unsure how to test this. I followed these instructions, but npm run test eventually produced

lean4:   Lean4 Bootstrap Test Suite
lean4: 22:36:27.017 - executeWithProgress lean +leanprover/lean4:nightly-2022-10-26,--version
lean4: 22:36:27.018 - =================== Install elan on demand ===================
lean4: 22:36:27.037 - child process exited with code 0
lean4: 22:36:27.048 - Loaded document untitled:Untitled-1
lean4: 22:36:27.048 - Setting lean4 language on untitled doc
lean4: 22:36:27.106 - child process exited with code 0
lean4: 22:36:27.117 - child process exited with code 0
lean4: 22:36:27.117 - executeWithProgress lean +nightly,--version
lean4: 22:36:27.133 - Waiting for extension leanprover.lean4 to be loaded...
lean4: 22:36:27.133 - Found extension: leanprover.lean4
lean4: 22:36:27.133 - Waiting for extension leanprover.lean4 activation...
lean4: 22:36:27.133 - Extension leanprover.lean4 isActive=true
lean4: 22:36:27.134 - Found lean package version: 0.0.123
lean4: 22:36:27.134 - Waiting for InfoView...
lean4: 22:36:27.134 - InfoView is open.
lean4: 22:36:27.134 - Wait for elan install of Lean nightly build...
lean4: 22:36:27.134 - Waiting for active client ...
lean4: 22:36:27.219 - child process exited with code 0
lean4: 22:36:27.219 - [ClientProvider] Creating LeanClient for untitled:
lean4: 22:36:27.219 - [ClientProvider] firing clientAddedEmitter event
lean4: 22:36:27.219 - [InfoProvider] Adding client for workspace: untitled:
lean4: 22:36:27.219 - [LeanClient] Restarting Lean Server
lean4: 22:36:27.225 - [LeanClient] starting
lean4: [main 2024-01-12T22:36:27.302Z] CodeWindow: failed to load (reason: <unknown>, code: -3)
lean4: 22:36:27.407 - [InfoProvider] initInfoView got null client.
lean4: 22:36:27.686 - [LeanClient] running, started in 466 ms
lean4: 22:36:27.689 - [InfoProvider] got client restarted event
lean4: 22:36:27.692 - [InfoProvider] initInfoView!
lean4: 22:36:28.134 - Waiting for active client to enter running state...

at which point the tests hung.

@mhuisi
Copy link
Collaborator

mhuisi commented Jan 15, 2024

I'm not sure why the tests are broken for you. They can be somewhat non-deterministic, but should always time out eventually. Additionally, there are no tests related to the abbreviations feature.

Do you still want to add the other abbreviations suggested in the thread before merging?

@girving girving changed the title feat: add "average": "⨍" to abbreviations feat: add "average": "⨍", "-int": "⨍", "oiint": "∯", "tint": "∯"` to abbreviations Jan 17, 2024
@girving girving changed the title feat: add "average": "⨍", "-int": "⨍", "oiint": "∯", "tint": "∯"` to abbreviations feat: abbreviate "average": "⨍", "-int": "⨍", "oiint": "∯", "tint": "∯"` Jan 17, 2024
@girving
Copy link
Contributor Author

girving commented Jan 17, 2024

I added the other abbreviations from Zulip.

@girving girving changed the title feat: abbreviate "average": "⨍", "-int": "⨍", "oiint": "∯", "tint": "∯"` feat: abbreviate "average": "⨍", "-int": "⨍", "oiint": "∯", "tint": "∯", "pd": "∂" Jan 17, 2024
@girving girving changed the title feat: abbreviate "average": "⨍", "-int": "⨍", "oiint": "∯", "tint": "∯", "pd": "∂" feat: abbreviate average: ⨍, -int: ⨍, oiint: ∯, tint: ∯, pd: ∂ Jan 17, 2024
@girving
Copy link
Contributor Author

girving commented Jan 17, 2024

In terms of tests, not sure what to do. It still runs through a few tests and then hangs, but as you say this is likely not related to abbreviations.json.

@mhuisi mhuisi merged commit a017ae5 into leanprover:master Jan 17, 2024
@girving girving deleted the average branch January 17, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants