Skip to content
This repository has been archived by the owner on Feb 25, 2020. It is now read-only.

add hsts headers to all ssl vhosts. #84

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add hsts headers to all ssl vhosts. #84

wants to merge 1 commit into from

Conversation

cz8s
Copy link
Contributor

@cz8s cz8s commented Oct 28, 2015

HSTS header for all users
Copied from bettercrypto.org.

Copied from bettercrypto.org
@micah
Copy link
Contributor

micah commented Oct 28, 2015

This is already being set in:

puppet/modules/site_apache/templates/vhosts.d/api.conf.erb: Header always set Strict-Transport-Security "max-age=31536000; includeSubDomains"
puppet/modules/site_apache/templates/vhosts.d/common.conf.erb: Header always set Strict-Transport-Security "max-age=31536000; includeSubDomains"
puppet/modules/site_static/templates/apache.conf.erb: Header always set Strict-Transport-Security: "max-age=15768000;includeSubdomains"

I agree that it should be put into the commonly included file, but if we do that, we should remove the existing ones and be sure that common one is included.

Also of interest is why some of these have a different max-age?

@cz8s
Copy link
Contributor Author

cz8s commented Oct 28, 2015

Having it in common would be nice. Then pixelated could use it. I will update this PR accordingly and find out why we have different TTLs

@micah
Copy link
Contributor

micah commented Feb 2, 2016

@cz8s - just wanted to check on the status of this, are you still planning on updating the PR and checking on the different TTLs?

@cz8s
Copy link
Contributor Author

cz8s commented Feb 2, 2016

Its on my to do list. But I won't work on this the next weeks.

@varac varac changed the base branch from develop to master November 23, 2016 13:33
@varac
Copy link
Contributor

varac commented Nov 23, 2016

@cz8s ping, do you still intend to look into this ?
I changed the pr to merge into master, which is our main branch now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants