check v before ecrecover #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #105 +/- ##
==========================================
+ Coverage 84.17% 84.19% +0.01%
==========================================
Files 12 12
Lines 910 911 +1
==========================================
+ Hits 766 767 +1
Misses 144 144
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #105 +/- ##
==========================================
+ Coverage 84.17% 84.19% +0.01%
==========================================
Files 12 12
Lines 910 911 +1
==========================================
+ Hits 766 767 +1
Misses 144 144
Continue to review full report at Codecov.
|
pinkiebell
reviewed
May 3, 2019
| const signer = Input.recoverSignerAddress(sigHashBuf, v, r, s); | ||
|
|
||
| input.setSig(r, s, v, signer); | ||
| if (v > 0) { |
There was a problem hiding this comment.
Do we just want to check v here? I assume we should check r and s to equals 0, too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #104
maybe also #102