Add Comment Liking Capability #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With success, if heart is not liked it will be made FULL, but if already liked heart will turn EMPTY
In the previous code the wrong hearts were targeted. That has been fixed.
stephenmckeon
approved these changes
May 20, 2024
| const modal = document.querySelector('#modal') | ||
| modal.querySelector('#modal-message').textContent = err | ||
| modal.className = '' | ||
| setTimeout(hideErrorModal,3000) |
There was a problem hiding this comment.
There should always be spacing after commas.
Suggested change
| setTimeout(hideErrorModal,3000) | |
| setTimeout(hideErrorModal, 3000) |
Comment on lines
+17
to
+33
| const handleServerSuccess = (res, heartTarget) => { | ||
| document.querySelector('#modal').className = 'hidden' | ||
| if(heartTarget.className === 'like-glyph'){ | ||
| heartTarget.textContent = FULL_HEART | ||
| heartTarget.className = 'activated-heart' | ||
| }else if(heartTarget.className === 'activated-heart'){ | ||
| heartTarget.textContent = EMPTY_HEART | ||
| heartTarget.className = 'like-glyph' | ||
| } | ||
| } | ||
|
|
||
| const handleLikeComment = (event) => { | ||
| const heartTarget = event.target | ||
| mimicServerCall() | ||
| .then(res => handleServerSuccess(res, heartTarget)) | ||
| .catch(handleServerError) | ||
| } |
There was a problem hiding this comment.
Doesn't look like res is being used (and if it were, try naming is response next time, just to be more clear).
Suggested change
| const handleServerSuccess = (res, heartTarget) => { | |
| document.querySelector('#modal').className = 'hidden' | |
| if(heartTarget.className === 'like-glyph'){ | |
| heartTarget.textContent = FULL_HEART | |
| heartTarget.className = 'activated-heart' | |
| }else if(heartTarget.className === 'activated-heart'){ | |
| heartTarget.textContent = EMPTY_HEART | |
| heartTarget.className = 'like-glyph' | |
| } | |
| } | |
| const handleLikeComment = (event) => { | |
| const heartTarget = event.target | |
| mimicServerCall() | |
| .then(res => handleServerSuccess(res, heartTarget)) | |
| .catch(handleServerError) | |
| } | |
| const handleServerSuccess = (heartTarget) => { | |
| document.querySelector('#modal').className = 'hidden' | |
| if(heartTarget.className === 'like-glyph'){ | |
| heartTarget.textContent = FULL_HEART | |
| heartTarget.className = 'activated-heart' | |
| }else if(heartTarget.className === 'activated-heart'){ | |
| heartTarget.textContent = EMPTY_HEART | |
| heartTarget.className = 'like-glyph' | |
| } | |
| } | |
| const handleLikeComment = (event) => { | |
| const heartTarget = event.target | |
| mimicServerCall() | |
| .then(handleServerSuccess) | |
| .catch(handleServerError) | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users are able to like comments with a heart icon and unlike previous comments. An error message will notify users when their like was unsuccessful due to a server issue giving them the chance to try again.