Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Ben!
I recently had to switch from using pyautogui to pydirectinput for one of my projects.
When trying to press
Z
, I realized the actual outcome wasY
, because your scancodes are QWERTY based, which means on a QWERTZ based keyboard, Y comes out as Z and vice versa, even worse for AZERTY layouts!So, as a quick fix for this (rather pesky) issue, we can simply use the
MapVirtualKey
as you already have been for the arrow keys, to make this slightly less code, we can simply iterate over all the keycodes and map them to their character.Since the function comes from ctypes too, theres no need for further imports and changes.
Hope this helps and is lightweight enough for you to simply accept it.
Thanks for your great work and videos!