Remove unnecessary cbor encoding for session transcript and in device…

… authentication
leecam · Feb 13, 2025 · 6f056af · 6f056af
1 parent e43500e
commit 6f056af
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/examples/device_response.py b/examples/device_response.py
@@ -14,7 +14,7 @@ def generate_device_response(doctype, issuer_signed, device_private_key, session
         "DeviceAuthentication",
         session_transcript,
         doctype,
-        cbor2.dumps(namespace_tag),
+        namespace_tag,
     ]
 
     device_authentication_bytes = cbor2.dumps(

diff --git a/examples/verify_mdoc.py b/examples/verify_mdoc.py
@@ -14,7 +14,7 @@
 issuer_signed = mdl.generate_credential(device_public_key)
 
 # Generate a device response, this would normally be created by the device's wallet.
-session_transcript = bytes(10)
+session_transcript = [None, None, ["handover", bytes(10)]]
 device_response = generate_device_response(
     "org.iso.18013.5.1.mDL", issuer_signed, device_private_key, session_transcript
 )

diff --git a/isomdoc/verify/verify_mdoc.py b/isomdoc/verify/verify_mdoc.py
@@ -217,7 +217,7 @@ def __init__(
         device_signed: dict,
         doctype: str,
         device_public_key: PublicKeyTypes,
-        session_transcript: bytes,
+        session_transcript: list,
     ):
 
         if "nameSpaces" not in device_signed:
@@ -267,7 +267,7 @@ def __init__(
             "DeviceAuthentication",
             session_transcript,
             doctype,
-            cbor2.dumps(namespace_tag),
+            namespace_tag,
         ]
 
         device_authentication_bytes = cbor2.dumps(
@@ -295,7 +295,7 @@ class Document:
     issuer_signed: IssuerSigned
     device_signed: DeviceSigned
 
-    def __init__(self, document: dict, session_transcript: bytes):
+    def __init__(self, document: dict, session_transcript: list):
         if "docType" not in document:
             raise RuntimeError("Document must contain docType")
         self.doctype = document["docType"]
@@ -316,7 +316,7 @@ def __init__(self, document: dict, session_transcript: bytes):
 class DeviceResponse:
     documents: Document
 
-    def __init__(self, device_response: bytes, session_transcript: bytes):
+    def __init__(self, device_response: bytes, session_transcript: list):
         self.documents = []
 
         device_response_dict = cbor2.loads(device_response)
@@ -340,5 +340,5 @@ def __init__(self, device_response: bytes, session_transcript: bytes):
         ]
 
 
-def verify_device_response(device_response: bytes, session_transcript: bytes) -> DeviceResponse:
+def verify_device_response(device_response: bytes, session_transcript: list) -> DeviceResponse:
     return DeviceResponse(device_response, session_transcript)