Use more modern streams2 streaming api #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -81,7 +82,7 @@ test('id4', function (t) { | |||
| t.strictEqual(result, 'Electronic', 'raw gnre'); | |||
| }) | |||
| .on('stik', function (result) { | |||
| t.strictEqual(result, 256, 'raw stik'); | |||
| t.strictEqual(result, 1, 'raw stik'); | |||
There was a problem hiding this comment.
1 is actually the correct value for stik, the previous implementation was broken.
| t.end(); | ||
| }) | ||
| .on('done', function (err) { | ||
| t.error(err) |
There was a problem hiding this comment.
Best to check done event in all tests too.
| @@ -16,5 +16,6 @@ test('mp3 cbr calculation', function (t) { | |||
| }) | |||
| .on('done', function (err) { | |||
| t.error(err); | |||
| t.end() | |||
There was a problem hiding this comment.
Better to call end when we can.
leetreveil
force-pushed
the
calippo
branch
3 times, most recently
from
0aa9323
to
f56e70d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.