-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StdGL: Move gamma calculation to shaders if shaders are enabled #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fulgen301
force-pushed
the
gamma_shader
branch
from
October 29, 2022 15:33
6489a8d
to
4a74655
Compare
Is this the desired or current behaviour? |
The current behavior - all other components (e.g. the shaders) log an error and exit the game if they cannot be created. |
Fulgen301
force-pushed
the
master
branch
4 times, most recently
from
January 17, 2023 16:57
e8594e9
to
5b1d4c0
Compare
Fulgen301
force-pushed
the
master
branch
2 times, most recently
from
January 28, 2023 13:43
576e440
to
ce836d5
Compare
Fulgen301
force-pushed
the
master
branch
2 times, most recently
from
February 6, 2023 17:05
bcedb99
to
a6dc0ab
Compare
Fulgen301
force-pushed
the
master
branch
2 times, most recently
from
March 24, 2023 09:54
8956ef7
to
d712f3f
Compare
Fulgen301
force-pushed
the
gamma_shader
branch
from
October 3, 2023 12:47
68d428c
to
da02a0e
Compare
This reverts commit e16e261.
… fix validation errors due to uniforms that have not yet been assigned a value to
Fulgen301
force-pushed
the
gamma_shader
branch
from
September 9, 2024 14:28
25bd7ca
to
4ec39dc
Compare
There is no reason to have that call there, and having it would require additional state tracking for gamma.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GLSL shaders now do the gamma calculation. For this purpose, the gamma ramp is directly copied into a 256x3 texture.
The old way of setting the system's gamma ramp directly is still used for the non-shader code path for older systems.
TODO:
DrawQuadDw
looks weird with certain gamma values, e.g. the example given in the docs.Graphics.DisableGamma
properly - the shader currently still samples the gamma texture even if gamma is disabled.DisableGamma
should disable any gamma-related code entirely.