Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ Added test to see if exception are passed up #601

Merged
merged 1 commit into from
Apr 6, 2024

Conversation

Guldem
Copy link
Contributor

@Guldem Guldem commented Apr 6, 2024

Added test to verify these are passed up in the chain.

See #167

Was bit to quick with cleaning up the branches on my github 🤦

See #600 for the first PR...

Copy link

codecov bot commented Apr 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.85%. Comparing base (d5a8d4a) to head (2c6bf7a).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #601   +/-   ##
========================================
  Coverage    92.85%   92.85%           
========================================
  Files           22       22           
  Lines          490      490           
========================================
  Hits           455      455           
  Misses          35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Guldem
Copy link
Contributor Author

Guldem commented Apr 6, 2024

Not gonna delete it this time 😆

@techouse
Copy link
Collaborator

techouse commented Apr 6, 2024

Not gonna delete it this time 😆

I'll leave it open for a while so you can experiment some more 😇

@techouse techouse merged commit 4fe8ccf into lejard-h:develop Apr 6, 2024
12 checks passed
@techouse techouse added this to the 8.0.0 milestone May 9, 2024
@techouse techouse added the enhancement New feature or request label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants