Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔖 release v8.0.0 #609

Merged
merged 164 commits into from
May 9, 2024
Merged

🔖 release v8.0.0 #609

merged 164 commits into from
May 9, 2024

Conversation

techouse
Copy link
Collaborator

@techouse techouse commented May 3, 2024

chopper

8.0.0

chopper_generator

8.0.0

chopper_built_value

3.0.0

  • Require Chopper ^8.0.0

yousinix and others added 30 commits May 25, 2021 09:26
Co-authored-by: István Juhos <[email protected]>
@techouse techouse added the release prod release label May 3, 2024
@techouse
Copy link
Collaborator Author

techouse commented May 3, 2024

@Guldem I have written a short migration guide around the Interceptors https://docs.google.com/document/d/1GkxktMbNi8VM5YzJwFuA19KMWeY96jrGmMsq867P28Y/edit?usp=sharing and plan to attach it to the changelog.

Would you mind checking it out and adding more info, notes and/or examples?

The publish dry run fails for the same reasons as in #606

CC / @JEuler

Copy link

codecov bot commented May 3, 2024

Codecov Report

Attention: Patch coverage is 95.45455% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 93.05%. Comparing base (ae505af) to head (e2b63e6).

Files Patch % Lines
...lib/src/interceptors/http_logging_interceptor.dart 95.45% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #609      +/-   ##
==========================================
+ Coverage   92.85%   93.05%   +0.19%     
==========================================
  Files          22       22              
  Lines         490      504      +14     
==========================================
+ Hits          455      469      +14     
  Misses         35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@techouse techouse changed the base branch from develop to master May 3, 2024 18:35
@Guldem
Copy link
Contributor

Guldem commented May 5, 2024

@Guldem I have written a short migration guide around the Interceptors https://docs.google.com/document/d/1GkxktMbNi8VM5YzJwFuA19KMWeY96jrGmMsq867P28Y/edit?usp=sharing and plan to attach it to the changelog.

Would you mind checking it out and adding more info, notes and/or examples?

The publish dry run fails for the same reasons as in #606

CC / @JEuler

I will check next Tuesday and add stuff if necessary 😄

@techouse
Copy link
Collaborator Author

techouse commented May 5, 2024

I will check next Tuesday and add stuff if necessary 😄

Thanx man! Much appreciated!

The link from the comment

https://docs.google.com/document/d/1GkxktMbNi8VM5YzJwFuA19KMWeY96jrGmMsq867P28Y/edit?usp=sharing

is to a an editable version. The link in the changelog and PR description is an immutable copy of that same document.

@techouse techouse added this to the 8.0.0 milestone May 5, 2024
@Guldem
Copy link
Contributor

Guldem commented May 7, 2024

I will check next Tuesday and add stuff if necessary 😄

Thanx man! Much appreciated!

The link from the comment

https://docs.google.com/document/d/1GkxktMbNi8VM5YzJwFuA19KMWeY96jrGmMsq867P28Y/edit?usp=sharing

is to a an editable version. The link in the changelog and PR description is an immutable copy of that same document.

I added some feedback and updated the examples. Why not just have a markdown file in the repository with the migration plan instead of a google docs?

@techouse
Copy link
Collaborator Author

techouse commented May 7, 2024

Why? I've seen this in a few other repos. So I thought why not do the same. 🤷‍♂️ It's probably down to the fact that the Google Doc can be updated outside of the repo.

@techouse techouse marked this pull request as ready for review May 8, 2024 18:38
Copy link
Contributor

@Guldem Guldem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@techouse
Copy link
Collaborator Author

techouse commented May 8, 2024

LGTM!

Thanx for the feedback and awesome PR #547 ♥️

Copy link
Collaborator

@JEuler JEuler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job guys! Thank you so much for being active!

@techouse techouse merged commit df9801a into master May 9, 2024
10 of 12 checks passed
@techouse techouse deleted the release/v8.0.0 branch May 9, 2024 07:59
@Guldem
Copy link
Contributor

Guldem commented May 10, 2024

LGTM!

Thanx for the feedback and awesome PR #547 ♥️

Great job guys! Thank you so much for being active!

@techouse @JEuler Thanks for feedback and support!

@techouse techouse mentioned this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release prod release
Projects
None yet
Development

Successfully merging this pull request may close these issues.