Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a keymap for the frame-multiplexer. #1237

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

mychris
Copy link
Contributor

@mychris mychris commented Jan 6, 2024

I am not sure about the name of the *keymap* variable.

Currently, there is a lot of repetition in init.el. If the variable is named *keymap*, the user writes this into it's init.el to remap it:

(define-key *global-keymap* "C-v" lem/frame-multiplexer:*keymap*)

But now, the name of the keymap does not match the of the variable. But naming the variable *frame-multiplexer-keymap* introduces a lot of repetition in init.el

(define-key *global-keymap* "C-v" lem/frame-multiplexer:*frame-multiplexer-keymap*)

What do you think? What is the name of the keymap used for, is it just for user information?

@cxxxr cxxxr merged commit 47325cb into lem-project:main Jan 9, 2024
1 check passed
@cxxxr
Copy link
Member

cxxxr commented Jan 9, 2024

I think *keymap* is a better reference here.
https://google.github.io/styleguide/lispguide.xml#Packages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants